Skip to content

feat: OTEL semantic convention compliance and req/resp metrics #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 13, 2025
Merged

feat: OTEL semantic convention compliance and req/resp metrics #32

merged 24 commits into from
Oct 13, 2025

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Oct 3, 2025 •
edited
Loading

this PR is really cool:

  • add service name to router, defaulting to ajj
  • comply with OTEL semantic conventions (see exception in README)
  • axum router now propagates traceparent details to the span :)
  • add metrics for requests received, processed, succeeded, errors, and responses sent/omitted
  • metric labels by service name and method
  • improve tracing span propagation to include more request lifecycle within the request span
  • delegate handler implementation to a macro to DRY it as much as possible
  • Simplify ResponsePayload by making a transparent wrapper around Result

@prestwich Graphite App
Copy link
Member Author

prestwich commented Oct 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich prestwich force-pushed the prestwich/enhance-otel branch 4 times, most recently from 14b8080 to a08b2e1 Compare October 3, 2025 15:47
@prestwich prestwich force-pushed the prestwich/enhance-otel branch from a08b2e1 to c32f7c6 Compare October 3, 2025 15:48
@prestwich prestwich marked this pull request as ready for review October 3, 2025 16:03
prestwich added 20 commits October 3, 2025 12:05
@prestwich prestwich changed the title feat: enhance otel implementation by setting more span info on request receipt feat: OTEL semantic convention compliance and req/resp metrics Oct 9, 2025
@prestwich prestwich force-pushed the prestwich/enhance-otel branch from c4ee6e0 to 1d05045 Compare October 9, 2025 15:33
@prestwich prestwich force-pushed the prestwich/enhance-otel branch from 1d05045 to e263b34 Compare October 9, 2025 16:03
@prestwich prestwich mentioned this pull request Oct 10, 2025
Merged
@prestwich prestwich requested a review from Evalir October 10, 2025 16:05
Evalir
Evalir approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k this is actually pretty cool

@prestwich prestwich merged commit fc74ea4 into main Oct 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evalir Evalir Evalir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prestwich @Evalir